Skip to content

Use 8.0.0 in core library #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use 8.0.0 in core library #19

wants to merge 1 commit into from

Conversation

jnyrup
Copy link
Member

@jnyrup jnyrup commented Jan 28, 2025 •
edited
Loading

Fixup to #17

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.

@jnyrup jnyrup requested a review from dennisdoomen January 28, 2025 10:04
dennisdoomen
dennisdoomen approved these changes Jan 28, 2025
View reviewed changes
@jnyrup
Copy link
Member Author

jnyrup commented Jan 28, 2025

Seems we have a bug in ExecuteCustomInitializers.
When only the test project uses 8.0.1Src\FluentAssertions.DataSets\InitializeDataSetSupport.cs is no longer found.

@dennisdoomen
Copy link
Member

When only the test project uses 8.0.1

Because 8.0.1 and 8.0.0 are not the same assembly?

@jnyrup
Copy link
Member Author

jnyrup commented Jan 28, 2025

When only the test project uses 8.0.1

Because 8.0.1 and 8.0.0 are not the same assembly?

I guess.
I didn't dive deeper into it.

@jnyrup jnyrup mentioned this pull request Feb 1, 2025
Merged
@jnyrup jnyrup closed this Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnyrup @dennisdoomen